Ellipsize pill component contents when too large #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FadhlanR
commented
Apr 3, 2024
FadhlanR
commented
habdelra
approved these changes
Apr 3, 2024
backspace
reviewed
Apr 3, 2024
| display: flex; | ||
| max-width: 100px; | ||
| } | ||
| :deep(.atom-format) { |
There was a problem hiding this comment.
nice, I didn’t realise this was possible 🤩
jurgenwerk
approved these changes
Apr 3, 2024
burieberry
approved these changes
Apr 4, 2024
jurgenwerk
reviewed
Apr 5, 2024
| get isTooltipDisplayed() { | ||
| // If card is an auto-attached card, we need to hide the tooltip | ||
| // because there is another tooltip shows "Topmost card is shared automatically". | ||
| return this._isTooltipDisplayed && !this.args.isAutoAttachedCard; |
There was a problem hiding this comment.
- There are now 2 clashing tooltips - how do you decide which one is more important?
- Logic got confusing because the pill component now has more context about its surroundings, for example needing to know there is another tooltip on top of it... ideally this should not be its responsibility
Have you considered what Buck suggested, a title attribute?
There was a problem hiding this comment.
Thanks for the feedback! I didn't realize about the title attribute before. I reverted the commit regarding the tooltip and implemented title attribute instead.
There was a problem hiding this comment.
Instead of adding title in field-component I moved it to card-pill in this PR so we don't need to update field-component and keep any changes in card-pill file.
FadhlanR
force-pushed
the
ellipsize-pill-component
branch
from
ffcf4c2 to
fae4d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.